Re: [PATCH v3] commit-tree: utilize parse-options api

From: Brandon Richardson <brandon1024.br@gmail.com>
Date: Mar 4, 2019, 18:46 UTC
Message-ID: <CAETBDP5UOqpBvuY=YFq6AAK4eDUAd3MU89Xi-Tra3rJgesLuvg@mail.gmail.com>
In-Reply-To: <CACsJy8D60NXksKpYJeDJbYKP6JUmrHEJW8ubMeV12dij+jXKLg@mail.gmail.com>

On Mon, Mar 4, 2019 at 7:18 AM Duy Nguyen <pclouds@gmail.com> wrote:

> You probably should mention about the extra _() too (e.g. "while at
> there, mark more strings for translation") just to be clear it's
> intentional.

Good call. Will update.

Show 6 quoted lines

> > +#include "parse-options.h"
> > +#include "string-list.h"
>
> Everything looks good, except that I can't find where this
> string-list.h is needed. Maybe just try to remove it and build to be
> sure.

You're right, string-list.h was not used. Removed.

Brandon