Re: [git-gui] Amending doesn't preserve timestamp

From: Juraj Oršulić <juraj.orsulic@fer.hr>
Date: Mar 24, 2017, 10:23 UTC
Message-ID: <CAEPqvow38g-X0nCLwMsMW4T+uu0ouDUQNmOGZp6BG0yjwR6pTQ@mail.gmail.com>
In-Reply-To: <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr>

Hi Igor! Thanks on for thoroughly searching the mailing list and on your suggestions. I hope that someone will come up with a fix that both preserves the author details and date correctly.

Regards, Juraj

On Thu, Mar 23, 2017 at 11:54 PM, Igor Djordjevic <igor.d.djordjevic@gmail.com> wrote:

Show 54 quoted lines

> Hi Juraj,
>
> On 23/03/2017 15:26, Juraj Oršulić wrote:
>> Hello Igor (and others), I have something else to report about the
>> commit amend functionality in git-gui, and I think it could be
>> related to my original question. It seems that git-gui messes up
>> international signs on amending.
>>
>> E.g. I use git gui to make a commit, and all is OK:
>>
>> commit ef24b133dda6c18b8ef01b1a38f9e049d87f2021
>> Author: Juraj Oršulić <juraj.orsulic@fer.hr>
>>
>> I open git gui again, click "Amend Last Commit", press "Commit", and I
>> get this in git log:
>>
>> commit 6e09ff9edcef863d92f02cf86e0307c27171aec0
>> Author: Juraj OrÅ¡uliÄ<U+0087> <juraj.orsulic@fer.hr>
>>
>>
>> Does anyone have any idea what could be the cause?
>>
>> I tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on
>> http://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72.
>
> Yes, I can confirm this.
>
> git version 2.12.1.windows.1
> git-gui version 0.21.GITGUI
> Tcl/Tk version 8.6.6
>
> That said, it seems there are quite some topics about it, like [1],
> [2], [3] and [4], but the most interesting one could be [5], having
> some kind of a "workaround" at the end as well.
>
> I`ve tried replacing the "commit.tcl" file as proposed, and it seems
> to work correctly -- just please do note that it actually reverts the
> file in question to an older version, maybe (re)introducing other
> bugs while fixing this specific one, so it could be something you may
> want to investigate into a bit more before actually using it for good.
>
> P.S. It might be a good idea to start a new topic in situations like
> this (send out a new e-mail instead of a reply), keeping unrelated
> discussions separated and helping interested parties spotting the new
> topic more easily.
>
> Regards,
> Buga
>
> [1] https://public-inbox.org/git/588ac268-0a1b-6787-e6a1-4164e7e9a784@b-i-t.de/T/#ea05ebbde162f9c230a2cc4f7099363aed68768f6
> [2] https://public-inbox.org/git/52E1627956F20E458D872C5961027EDC654FE17C@SGDS00759.zf-lenksysteme.net/T/#m0baea8c76e79f25bf92ca0deabe38efec2ee168d
> [3] https://public-inbox.org/git/50913C58.2000200@drmicha.warpmail.net/T/#m72664106ad3070235ea2628b61fc6203fbb5563e
> [4] https://public-inbox.org/git/20071212091744.GA5377@pvv.org/T/#m8490dd348389b4eea82eb1bdaab69227c946de19
> [5] https://github.com/git-for-windows/git/issues/761