Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi,

On Fri, Jan 5, 2018 at 11:45 AM, Yasushi SHOJI <yasushi.shoji@gmail.com> wrote:

OK, here is the step to reproduce on git.git

$ git bisect start $ git bisect bad v2.16.0-rc0 $ git bisect good 0433d533f13671f4313c31e34707f0f5281a18e0 $ git bisect good $ git bisect bad $ git bisect bad $ git bisect skip #=> works with error $ git bisect good #=> Segmentation fault $ git bisect skip #=> Segmentation fault

The following is with full outputs, just in case you need it.

$ git describe v2.16.0-rc0

$ git bisect start $ git bisect bad v2.16.0-rc0

$ git bisect good 0433d533f13671f4313c31e34707f0f5281a18e0
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[c87b653c46c4455561642b14efc8920a0b3e44b9] builtin/describe.c: rename
`oid` to avoid variable shadowing

$ git bisect good
Bisecting: 2 revisions left to test after this (roughly 1 step)
[4dbc59a4cce418ff8428a9d2ecd67c34ca50db56] builtin/describe.c: factor
out describe_commit

$ git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cdaed0cf023a47cae327671fae11c10d88100ee7] builtin/describe.c: print
debug statements earlier

$ git bisect bad
cdaed0cf023a47cae327671fae11c10d88100ee7 is the first bad commit
commit cdaed0cf023a47cae327671fae11c10d88100ee7
Author: Stefan Beller <sbeller@google.com>
Date:   Wed Nov 15 18:00:37 2017 -0800

    builtin/describe.c: print debug statements earlier

    When debugging, print the received argument at the start of the
    function instead of in the middle. This ensures that the received
    argument is printed in all code paths, and also allows a subsequent
    refactoring to not need to move the "arg" parameter.

    Signed-off-by: Stefan Beller <sbeller@google.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

:040000 040000 beb1f2c4d9ee7584e54e0489c7e85e348cbf9fc7 b9882eea0772e3025690d3513cea5a940567668e M builtin

$ git bisect skip There are only 'skip'ped commits left to test. The first bad commit could be any of: cdaed0cf023a47cae327671fae11c10d88100ee7 We cannot bisect more!

$ git bisect good Segmentation fault

$ git bisect skip Segmentation fault