Re: [PATCH] [RFC] Make git-update-ref invoke the update and post-update hooks

From: Brian Vandenberg <phantall@gmail.com>
Date: Jun 16, 2015, 14:31 UTC
Message-ID: <CAEJ-0i-QptjYLtr0CnYOgt4X+2R5tQGZqRhicFdxAPBxNA8J7Q@mail.gmail.com>
In-Reply-To: <xmqqd20w7ii4.fsf@gitster.dls.corp.google.com>

On Mon, Jun 15, 2015 at 3:45 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Those who want to bypass your policy can use "vi .git/packed-refs"
> and/or "rm .git/refs/heads/foo"; you would not propose to patch "rm"
> and "vi" to pay attention to git configuration, because they are not
> about "git" at all, and there are cases where these bare-metal level
> editing of repositories is necessary.  You would instead tell them
> "don't do that".
>
> When I say "update-ref is a low-level plumbing command that should
> not enforce policy", I am suggesting you to treat the command just
> like you would treat "rm" and "vi".

I suppose I see your point, though the line they've crossed at that point is from benign to malicious.

When you assume they've crossed that line, hooks and configuration parameters are mostly useless in other git commands as well. My assumption here is they want to do something productive and aren't intentionally seeking to subvert policies, but rather aren't aware of the policies and/or correct procedure.

Thanks for your responses, I appreciate your time.

-Brian