Fwd: Delivery Status Notification (Failure)

From: Drew Gross <drew.a.gross@gmail.com>
Date: Apr 6, 2013, 04:15 UTC
Message-ID: <CAECh7fD6SKtfZudByeVD_HUjxN-fHBF1bA+pVM6=gV=Jy5Uhwg@mail.gmail.com>
In-Reply-To: <047d7b3a85a201067604d9a948e8@google.com>

Hello,

I'm am trying to patch git to refuse to commit if there are both staged and unstaged changes, and I pass the -a flag. I expected this simple addition to parse_and_validate_options() in commit.c to accomplish most of what I want:

if (all && s->workdir_dirty)
    die(_("Cannot commit with -a if there are staged and unstaged changes"));

But when compiled, this will commit anyway even with staged and unstaged files. I think I misunderstanding the workdir_dirty flag. Can someone help me?

Drew Gross