Re: Credentials and the Secrets API...
- From
John Szakmeister <john@szakmeister.net>
- Date
- Nov 1, 2011, 06:39 UTC
- Message-ID
- <CAEBDL5XOnsq1zBRq+f1zKJqQvxJjRPywCRbPKn77x9Yaa4QVkA@mail.gmail.com>
- In-Reply-To
- <20111027174807.GD1967@sigill.intra.peff.net>
On Thu, Oct 27, 2011 at 1:48 PM, Jeff King <peff@peff.net> wrote:
> On Thu, Oct 27, 2011 at 12:05:03PM -0400, John Szakmeister wrote:
[snip]
Show 7 quoted lines
>> With that information, I went ahead and created a >> gnome-credential-keyring that uses Gnome's Keyring facility. I still >> need to do a few more things (mainly run it against Jeff's tests), but >> it's generally working. Just wanted to keep folks in the loop. >> Hopefully, I can get patches out this weekend. > > Great, I'm looking forward to reading it.
I've pushed up the work I've done to: <https://github.com/jszakmeister/git-credential-keyring>
There's not much to it. It also doesn't handle certs and that sort of thing. I think we need to figure out which protocols need to be handled differently so that we can use the appropriate api for the keyring-like api. :-)
I also chose this way instead of a patch to git, because it appears your work is no longer in pu (I must have missed the fact that it was removed). Once your work makes it way back in, I can look into getting it into the contrib area, if that's desired.
Show 6 quoted lines
>> Jeff: it would be really excellent to break out the various pieces. I >> think it would also be better to split the asking for passwords from >> the storing of passwords. > > That's my current plan. I just need to stop dragging my feet on > re-rolling the series.
Sounds good! I'll be happy to update when you do re-roll it. The test you sent out was very helpful, BTW. I do think the test cases with no context are a bit broken though. It doesn't seem right to ask the storage backend to retrieve a password without any context at all, IMHO. My implementation doesn't pass those two tests. It does pass the rest of them though.
-John