git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] Make libintl in libc detection more robust

From
John Szakmeister <john@szakmeister.net>
Date
Feb 20, 2012, 13:40 UTC
Message-ID
<CAEBDL5WzYFWdnF=pqHq3wc3GRU-pxS6=1Xw8LP=cogck8wYAAg@mail.gmail.com>
In-Reply-To
<7vd399nbt2.fsf@alter.siamese.dyndns.org>
On Mon, Feb 20, 2012 at 3:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> John Szakmeister <john@szakmeister.net> writes:
>
>> This is my first time submitting a patch to git.  I hope I've done
>> things correctly!
>
> Looks good, except for the subject line that would have been better to say
> something like:
>
>    configure: don't use -lintl when there is no gettext support

You're right, that's much better. I'll keep your feedback in mind for next time.

> I'll tweak the log message and queue.
Thanks Junio!
-John
Previous: Junio C Hamano
Message 4 of 4 in “Make libintl in libc detection more robust”
  1. 0/1 Make libintl in libc detection more robustJohn Szakmeister, Feb 18, 2012
  2. 1/1 Don't append -lintl when there is no gettext supportJohn Szakmeister, Feb 18, 2012
  3. Junio C HamanoFeb 20, 2012
  4. John SzakmeisterFeb 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.