Re: [BUG] clone: regression in error messages in master

From: John Szakmeister <john@szakmeister.net>
Date: Jun 22, 2013, 09:55 UTC
Message-ID: <CAEBDL5WYCdMEOsoXtxgfNDmJrkj2DR8DgTwKY72iUJjQyJ-bRw@mail.gmail.com>
In-Reply-To: <7vli63mlro.fsf@alter.siamese.dyndns.org>

On Fri, Jun 21, 2013 at 1:11 PM, Junio C Hamano <gitster@pobox.com> wrote:

> John Szakmeister <john@szakmeister.net> writes:

[snip]

Show 9 quoted lines

>> I can see where this is confusing, but can also see how it's useful
>> information to have.  On clone, it's probably not that useful since
>> you're looking right at the url, but I could see that information
>> being more useful on a pull or push with the default arguments (when
>> the source and destination aren't quite as obvious).
>
> The "extra" error messages is not the first one, but the last one,
> and the suggested revert is a proposal to remove the latter, not the
> "repository $URL not found".

Sorry for the confusion. I realize they were talking about removing the remote helper line. What I meant was that with the url there, it's a bit easier to determine which part of git failed (http, hg, or bzr remote helper, for instance). What I was trying to say was perhaps there are paths through here where it's really helpful to know that things failed in the remote helper, so we may not want to wholesale remove it. Some of remote helpers, such as ones that talk to foreign VCSes, do quite a bit more than just transfer data, so it might be helpful to know that it's not core git that's failing but the remote helper. Seeing the URL is a reminder that you're interacting with a remote helper, and it may not be helpful there. But other commands don't necessarily show that to you, and it may be more helpful to have that reminder that it was a remote helper that failed.

I hope that makes more sense.

-John