Re: gitweb.cgi bug - XML Parsing Error: not well-formed

From: Dongsheng Song <dongsheng.song@gmail.com>
Date: Feb 18, 2014, 14:57 UTC
Message-ID: <CAE8XmWpvQrW0Us309teZ_E8hvJWS8ihaGhOsU94EkOjeypGzhg@mail.gmail.com>
In-Reply-To: <7A867C8D-4F20-44C2-BE16-7EF81E799998@kellerfarm.com>

What's your mean ?

I think I had post enough information:

When I access https://xxx.info/repo/git?p=DRE/Reference.git;a=commitdiff;h=fbd4e74c867214062ad39282a899f1d14a2e89ba

Then gitweb.cgi generate invalid XHTML:

<div class="patch" id="patch19"> <div class="diff header">diff --git a/RFC/2010/DRE-2010-004 RFC for Update Synchronization Program & Solve the Balance Adjustment Issue v2.doc <a class="path" href="/repo/git?p=DRE/Reference.git;a=blob;f=RFC/2010/DRE-2010-004+RFC+for+Update+Synchronization+Program+%26+Solve+the+Balance+Adjustment+Issue+v2.doc;h=3074448e2e68235e891ebd1301e6277d993973a5;hb=fbd4e74c867214062ad39282a899f1d14a2e89ba">b/RFC/2010/DRE-2010-004 RFC for Update Synchronization Program & Solve the Balance Adjustment Issue v2.doc</a></div> <div class="diff extended_header"> new file mode 100644<span class="info"> (file)</span><br/> index 0000000..<a class="hash" href="/repo/git?p=DRE/Reference.git;a=blob;f=RFC/2010/DRE-2010-004+RFC+for+Update+Synchronization+Program+%26+Solve+the+Balance+Adjustment+Issue+v2.doc;h=3074448e2e68235e891ebd1301e6277d993973a5;hb=fbd4e74c867214062ad39282a899f1d14a2e89ba">3074448</a><br/> Binary files /dev/null and b/RFC/2010/DRE-2010-004 RFC for Update Synchronization Program & Solve the Balance Adjustment Issue v2.doc differ<br/> </div> </div>

The last 'Program & Solve' should be 'Program &amp; Solve'

Regards, Dongsheng

On Tue, Feb 18, 2014 at 10:34 PM, Andrew Keller <andrew@kellerfarm.com> wrote:

Show 10 quoted lines

> On Feb 18, 2014, at 6:41 AM, Dongsheng Song <dongsheng.song@gmail.com> wrote:
>
>> Here is gitweb generated XHTML fragment:
>>
>> …
>
> You're going to have to be more specific.
>
>  - Andrew
>