Re: Weird (seemingly flakey) p4 breakage in t9833

From: Luke Diamand <luke@diamand.org>
Date: Feb 6, 2019, 11:54 UTC
Message-ID: <CAE5ih7_s+GZo10DMkhbkfoRPGovHZZo8q3qBaPKq8_uDdxrX0Q@mail.gmail.com>
In-Reply-To: <20190206111111.GK10587@szeder.dev>

On Wed, 6 Feb 2019 at 11:11, SZEDER Gábor <szeder.dev@gmail.com> wrote:

Show 14 quoted lines

>
> On Wed, Feb 06, 2019 at 11:33:21AM +0100, Johannes Schindelin wrote:
> > Hi Luke,
> >
> > in a private Azure Pipeline (sorry...) I noticed an intermittent problem
> > in the p4 tests on osx-gcc.
> >
> > I would point you to a public log, but the Azure Pipelines support *just*
> > made it to next, so I *just* set up a public one targeting anything else
> > than my `vsts-ci` branch, at
> > https://dev.azure.com/gitgitgadget/git/_build/index?definitionId=6. And
> > those builds do not show that problem, so it must be a flakey test.
> >
> > But maybe you can spot anything familiar from the log?

I think you're right - it's 'git operation with expired ticket'.

I wonder if we could make a faked-up Perforce client which returned the correct error data - then it wouldn't need to wait at all.

Or we could just remove it (or make it optional based on an environment variable).

Let me know which you think is best and I'll put together a patch.

Luke