git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: fix filetype detection on files opened exclusively

From
Luke Diamand <luke@diamand.org>
Date
Apr 2, 2015, 19:54 UTC
Message-ID
<CAE5ih7_QpkX-U+XJ8gKSKKt1+Vu+FM4XBADTkys-4MDa129jyw@mail.gmail.com>
In-Reply-To
<2D2A7688059E344DB86768405D63DEB42D3D75FC@USCULXMSG09.am.sony.com>
(+Pete for interest).

On 31 March 2015 at 22:54, Holloway, Blair <Blair_Holloway@playstation.sony.com> wrote:

> If a Perforce server is configured to automatically set +l (exclusive lock) on
> add of certain file types, git p4 submit will fail during getP4OpenedType, as
> the regex doesn't expect the trailing '*exclusive*' from p4 opened:

Thanks - that actually fixes a part of the long-standing problem of handling locked files which Pete identified about a year ago.

There's a test case for handling of locked files, t9816-git-p4-locked.sh, which needs updating now as a bit more of it passes. Junio, I'll submit a followup patch to update those tests once I get back from vacation.

(Fixing t9816 is very slightly non-trivial because test #4 is subtly broken and so incorrectly passes).

Ack, Luke

Previous: Holloway, BlairNext: Junio C Hamano
Message 2 of 3 in “git-p4: fix filetype detection on files opened exclusively”
  1. git-p4: fix filetype detection on files opened exclusivelyHolloway, Blair, Mar 31, 2015
  2. Luke DiamandApr 2, 2015
  3. Junio C HamanoApr 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.