git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/5] git-p4: add support for large file systems

From
Luke Diamand <luke@diamand.org>
Date
Sep 8, 2015, 04:25 UTC
Message-ID
<CAE5ih7_9CfGw51Aw8J8d2m=s3Z9sf8LV9p84SynrpCW4k0Vbxg@mail.gmail.com>
In-Reply-To
<1441628478-86503-1-git-send-email-larsxschneider@gmail.com>
On 7 September 2015 at 13:21,  <larsxschneider@gmail.com> wrote:
Show 5 quoted lines
> From: Lars Schneider <larsxschneider@gmail.com>
>
> One thing I don't like about the current implementation is that I don't see a
> way to test the "git-p4.pushLargeFiles" config. I could start a git lfs server
> locally but that seems a bit too much, no?

Perhaps add a trivial large-file derived class that just does enough to show that it's all working. Then the final bit of pushing the large files to LFS would remain forever untested, but it would be small enough and simple enough not to be a real problem. If it ever broke, it would indicate that either the trivial test class was a bit too trivial, or that the abstraction was not abstract enough and there's too much common-code in the derived classes.

Luke
Previous: larsxschneider@gmail.com
Message 7 of 7 in “git-p4: add support for large file systems”
  1. 0/5 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 7, 2015
  2. 1/5 git-p4: add optional type specifier to gitConfig readerlarsxschneider@gmail.com, Sep 7, 2015
  3. 2/5 git-p4: add gitConfigInt readerlarsxschneider@gmail.com, Sep 7, 2015
  4. 3/5 git-p4: return an empty list if a list config has no valueslarsxschneider@gmail.com, Sep 7, 2015
  5. 4/5 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 7, 2015
  6. 5/5 git-p4: add Git LFS backend for large file systemlarsxschneider@gmail.com, Sep 7, 2015
  7. Luke DiamandSep 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.