Re: [PATCH] Adding list of p4 jobs to git commit message

> Jan Durovec <jan.durovec@gmail.com> writes:
>
>> ---
>
> A few issues.  Please:
>
>  (1) Sign-off your work.
>
>  (2) Try to find those who are familiar with the area and Cc them.
>
>      "git shortlog -s -n --since=18.months --no-merges git-p4.py"
>      may help.
>
>  (3) Follow the style of existing commits when giving a title to
>      your patch.
>
>      "git shortlog --since=18.months --no-merges git-p4.py" may
>      help you notice "git-p4: do this thing" is the common way to
>      title "git p4" patches.
>
>  (4) Justify why your change is a good thing in your log message.
>      What you did, i.e. "list p4 jobs when making a commit", can be
>      seen by the patch, but readers cannot guess why you thought it
>      is a good idea to extract "job%d" out of the P4 commit and to
>      record them in the resulting Git commit, unless you explain
>      things like:
>
>      - what goes wrong if you don't?
>      - when would "job%d" appear in P4 commit?
>      - is it sane to assume "job0", "job1",... appear consecutively?
>
>  (5) Describe what your change does clearly.  "Adding list" is not
>      quite clear.  Where in the "git commit message" are you adding
>      the list, and why is that location in the message the most
>      appropriate place to add it?