Re: Git p4 sync changelist interval

From: Luke Diamand <luke@diamand.org>
Date: Jun 6, 2017, 10:54 UTC
Message-ID: <CAE5ih79_0XhT6Nb5WMki0kCZ_FaWSCYc5H=fZmp3esQSN-tF1w@mail.gmail.com>
In-Reply-To: <CAKOu8-2mB=fcFUd86vdK+z==0bX3rUvY-VuNjQ-C6t++uik8YQ@mail.gmail.com>

On 6 June 2017 at 08:56, Андрей Ефанов <1134togo@gmail.com> wrote:

Show 22 quoted lines

>>
>> It seems to be something to do with the code around line 3395 that says:
>>
>>     if self.changeRange == "@all":
>>         self.changeRange = ""
>>     elif ',' not in self.changeRange:
>>
>> It's finding a lower revision number with which to later call
>> importHeadRevision(), but that only seems to be called if the revision
>> range does *not* have a "," in it. As a result, we never actually call
>> importHeadRevision() and so files end up missing.
>>
>> The obvious fix of fishing out the "@3" from the "@3,5" revision range
>> works in this instance, but breaks some of the regression tests.
>>
>> Luke
>
> I did the same change before and it worked for me. I'd like to find
> out if it is a bug (I think it is), a normal behavior or am I doing
> something wrong.
>
> So according to what you say, it is a bug.

It's a bug!

I think you can workaround it by doing:

$ git p4 clone //depot@3 $ git p4 sync

I'll see if I can workout why my obvious fix caused the tests to fail.