git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH V3 0/2] git-p4: improve client path detection when branches are used

From
Luke Diamand <luke@diamand.org>
Date
Apr 23, 2015, 10:03 UTC
Message-ID
<CAE5ih79Ju6D0mZ75Z1UH2n2O6s9AWuxNgpojr=vTggEYY=7E3w@mail.gmail.com>
In-Reply-To
<9A7A7CAA-66D5-48B4-83E7-267FDDA7C66A@gmail.com>
On 23 April 2015 at 09:37, Vitor Antunes <vitor.hda@gmail.com> wrote:
Show 22 quoted lines
> That was a good combination to test. In fact, I am using such
> a client spec at my work place to exclude the import from
> Perforce of a folder that only contains binary files, but I never
> even considered to add files to that folder from git!
> Although I do agree that git-p4 should be able to exit sanely
> in this scenario, it is also my opinion that this is a different
> scenario from the one I'm tryig to fix in this set of patches and
> that it should not be enough to stop this merge.
>
> I will take this scenario into consideration, create a new test
> case and finally fix git-p4 to exit sanely in such a scenario.
> This new test will also be able to show that folder exclusion
> is working perfectly during import, which is important to
> guarantee that that functionality is not broken in future.
>
> BTW, no kudos is necessary because I've already walked this
> path before :) I've introduced branchList and improved how
> git-p4 looks for the original changelist used to create the new
> branch in Perforce side. If I remember correctly, many of the
> test cases in 9801 file were also created by me before Pete
> started splitting the git-p4 test file into topics.
>

Yes, I think you're right that this is a different, albeit related problem. It was broken before, and it's still broken. So I'm happy with this change - Ack.

Teaching git-p4 to handle this corner case would be a good thing to do as a separate followup if you're OK to do that.

Thanks! Luke

Previous: Vitor Antunes
Message 7 of 7 in “git-p4: improve client path detection when branches are used”
  1. 0/2 git-p4: improve client path detection when branches are usedVitor Antunes, Apr 21, 2015
  2. 1/2 t9801: check git-p4's branch detection with client spec enabledVitor Antunes, Apr 21, 2015
  3. 2/2 git-p4: improve client path detection when branches are usedVitor Antunes, Apr 21, 2015
  4. Junio C HamanoApr 22, 2015
  5. Luke DiamandApr 22, 2015
  6. Vitor AntunesApr 23, 2015
  7. Luke DiamandApr 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.