Bug in "revision.c: --all adds HEAD from all worktrees" ?

From: Luke Diamand <luke@diamand.org>
Date: Nov 13, 2017, 19:51 UTC
Message-ID: <CAE5ih78nLL6UhKPObvFEA9xQZUtc1XpPvGJNaYTH9fJ0RyFRvA@mail.gmail.com>

Hi!

I think there may be a regression caused by this change which means that "git fetch origin" doesn't work:

commit d0c39a49ccb5dfe7feba4325c3374d99ab123c59 (refs/bisect/bad)
Author: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date:   Wed Aug 23 19:36:59 2017 +0700

    revision.c: --all adds HEAD from all worktrees

$ git fetch origin fatal: bad object HEAD error: ssh://my_remote_host/reponame did not send all necessary objects

I used git bisect to find the problem, and it seems pretty consistent. "git fetch" with the previous revision works fine.

FWIW, I've got a lot of git worktrees associated with this repo, so that may be why it's failing. The remote repo is actually a git-p4 clone, so HEAD there actually ends up pointing at refs/remote/p4/master.

Thanks, Luke