Re: git-p4: t9819 failing

From: Luke Diamand <luke@diamand.org>
Date: Sep 24, 2015, 07:45 UTC
Message-ID: <CAE5ih78m9RbD=s_12ckA+yzRP=fuiruF=kasUSFZEjUZZA21UQ@mail.gmail.com>
In-Reply-To: <F37BA8D8-6845-4C47-BBE2-3313685FD16F@gmail.com>

On 23 September 2015 at 13:28, Lars Schneider <larsxschneider@gmail.com> wrote:

Show 14 quoted lines

>
>> Here's the last bit of the crash dump from git-p4 I get:
>>
>>  File "/home/ldiamand/git/git/git-p4", line 2580, in streamP4FilesCbSelf
>>    self.streamP4FilesCb(entry)
>>  File "/home/ldiamand/git/git/git-p4", line 2497, in streamP4FilesCb
>>    required_bytes = int((4 * int(self.stream_file["fileSize"])) -
>> calcDiskFree(self.cloneDestination))
>>  File "/home/ldiamand/git/git/git-p4", line 116, in calcDiskFree
>>    st = os.statvfs(dirname)
>> OSError: [Errno 2] No such file or directory: 'lc'
>>
>> Luke
> Confirmed. What do you think about this fix?

Works for me!

Show 21 quoted lines

>
> Thank you,
> Lars
>
> ---
>  git-p4.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/git-p4.py b/git-p4.py
> index 1d1bb87..66c0a4e 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -3478,6 +3478,7 @@ class P4Clone(P4Sync):
>
>          print "Importing from %s into %s" % (', '.join(depotPaths), self.cloneDestination)
>
> +        self.cloneDestination = os.path.abspath(self.cloneDestination)
>          if not os.path.exists(self.cloneDestination):
>              os.makedirs(self.cloneDestination)
>          chdir(self.cloneDestination)
> --