git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/14] git-p4: python3 compatibility

From
Luke Diamand <luke@diamand.org>
Date
Feb 3, 2020, 12:54 UTC
Message-ID
<CAE5ih78dpmPhdsR73cwGJuDYQECDaCvdOuosOAhLyLun9DyL_A@mail.gmail.com>
In-Reply-To
<CAE5ih7-ngXsn1+RYSJ9qk_Ajr9x9zLRWNCyUiBGjg=sx_cOuzA@mail.gmail.com>
On Thu, 30 Jan 2020 at 13:35, Luke Diamand <luke@diamand.org> wrote:
Show 9 quoted lines
>
> On Fri, 24 Jan 2020 at 20:14, Luke Diamand <luke@diamand.org> wrote:
> >
> > On Fri, 17 Jan 2020 at 22:00, Yang Zhao <yang.zhao@skyboxlabs.com> wrote:
> > >
> > > On Fri, Dec 13, 2019 at 3:53 PM Yang Zhao <yang.zhao@skyboxlabs.com> wrote:
> > > > This patchset adds python3 compatibility to git-p4.
> > >
> > > Ping?
One very small bug report:

When doing "git p4 sync" it prints out the percent complete. It looks like it's no longer rounding it sensibly, so where before it would say 77%, now it says 77.7777777%.

It's this line:
   sys.stdout.write("\rImporting revision %s (%s%%)" % (change, cnt *
100 / len(changes)))
I think / just needs replacing with //.
Show 15 quoted lines
> >
> > Hi!
> >
> > Sorry, I've been a bit busy.
> >
> > I quickly tried this and it was failing for me with:
> >
> > > failure accessing depot: could not connect
> >
> > It works fine with the interpreter set to /usr/bin/python, but
> > changing it to python3 caused this problem.
> >
> > I'm at 050387ce43179f1b0da364dd6eec10ce578d6583.
>
> I'm using it for day-to-day work, so far it's working well, thanks!
Previous: Luke DiamandNext: Yang Zhao
Message 5 of 22 in “git-p4: python3 compatibility”
  1. 00/14 git-p4: python3 compatibilityYang Zhao, Dec 13, 2019
  2. Yang ZhaoJan 17, 2020
  3. Luke DiamandJan 24, 2020
  4. Luke DiamandJan 30, 2020
  5. Luke DiamandFeb 3, 2020
  6. Yang ZhaoFeb 3, 2020
  7. Yang ZhaoFeb 4, 2020
  8. 01/14 git-p4: make python2.7 the oldest supported versionYang Zhao, Dec 13, 2019
  9. 02/14 git-p4: change the expansion test from basestring to listYang Zhao, Dec 13, 2019
  10. 05/14 git-p4: encode/decode communication with git for python3Yang Zhao, Dec 13, 2019
  11. 03/14 git-p4: remove string type aliasingYang Zhao, Dec 13, 2019
  12. 04/14 git-p4: encode/decode communication with p4 for python3Yang Zhao, Dec 13, 2019
  13. Junio C HamanoDec 17, 2019
  14. 08/14 git-p4: use marshal format version 2 when sending to p4Yang Zhao, Dec 13, 2019
  15. 07/14 git-p4: open .gitp4-usercache.txt in text modeYang Zhao, Dec 13, 2019
  16. 06/14 git-p4: convert path to unicode before processing themYang Zhao, Dec 13, 2019
  17. 09/14 git-p4: fix freezing while waiting for fast-import progressYang Zhao, Dec 13, 2019
  18. 10/14 git-p4: use functools.reduce instead of reduceYang Zhao, Dec 13, 2019
  19. 12/14 git-p4: simplify regex pattern generation for parsing diff-treeYang Zhao, Dec 13, 2019
  20. 11/14 git-p4: use dict.items() iteration for python3 compatibilityYang Zhao, Dec 13, 2019
  21. 14/14 ci: also run linux-gcc pipeline with python3.5 environmentYang Zhao, Dec 13, 2019
  22. 13/14 git-p4: use python3's input() everywhereYang Zhao, Dec 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.