Re: [PATCH] allow git-p4 to create shelved changelists

From: Luke Diamand <luke@diamand.org>
Date: Nov 29, 2016, 12:47 UTC
Message-ID: <CAE5ih78+br88ST3Hkiw744V62AZ9iYWZ4nD5EYjewfmQRWvsiw@mail.gmail.com>
In-Reply-To: <xmqqeg1vjug2.fsf@gitster.mtv.corp.google.com>

On 28 November 2016 at 19:06, Junio C Hamano <gitster@pobox.com> wrote:

> Vinicius Kursancew <viniciusalexandre@gmail.com> writes:
>
>> This patch adds a "--shelve" option to the submit subcommand, it will
>> save the changes to a perforce shelve instead of commiting them.

Looks good to me, thanks!

Works a treat.

Ack.

Show 14 quoted lines

>>
>> Vinicius Kursancew (1):
>>   git-p4: allow submit to create shelved changelists.
>>
>>  Documentation/git-p4.txt |  5 +++++
>>  git-p4.py                | 36 ++++++++++++++++++++++--------------
>>  t/t9807-git-p4-submit.sh | 31 +++++++++++++++++++++++++++++++
>>  3 files changed, 58 insertions(+), 14 deletions(-)
>
> Thanks, but I am a wrong person to review this change, so I'll
> summon two people who appear in "git shortlog --since=18.months"
> output to help review it.
>
>