Re: [PATCH v1] git-p4: map a P4 user to Git author name and email address

From: Luke Diamand <luke@diamand.org>
Date: Feb 29, 2016, 05:12 UTC
Message-ID: <CAE5ih7-oPE1RYrO78TAnkNSi03qtcUK_iiLywoyRC_FAgdwTAg@mail.gmail.com>
In-Reply-To: <1456655125-17829-1-git-send-email-larsxschneider@gmail.com>

On 28 February 2016 at 10:25,  <larsxschneider@gmail.com> wrote:

Show 5 quoted lines

> From: Lars Schneider <lars.schneider@autodesk.com>
>
> Map a P4 user to a specific name and email address in Git with the
> "git-p4.mapUser" config. The config value must be a string adhering
> to the format "p4user -> First Lastname <email@address.com>".

Seems generally fine. I agree with Eric's comments about the "->" format. One comment below:

Show 8 quoted lines

> +test_expect_success 'Clone repo root path with all history' '
> +       client_view "//depot/... //client/..." &&
> +       test_when_finished cleanup_git &&
> +       (
> +               cd "$git" &&
> +               git init . &&
> +               git config --add git-p4.mapUser "mmax -> Max Mustermann <max@muster.com>"  &&
> +               git config --add git-p4.mapUser "mo -> Moritz Untreu <moritz@untreu.com>" &&

Probably better to use more innocuous names. I'm not sure who these people are, but they might not appreciate being recorded forver in a git-p4 test script.

Luke