Re: [PATCH v2 3/3] git-p4: add "Nvidia Corporation" to copyright header

From: Luke Diamand <luke@diamand.org>
Date: Dec 10, 2021, 18:57 UTC
Message-ID: <CAE5ih7-nAOviVmuDbAWXONcY-FkR6xUDu_vTZhWz8_RTpDpsMg@mail.gmail.com>
In-Reply-To: <20211210153101.35433-4-jholdsworth@nvidia.com>

On Fri, 10 Dec 2021 at 15:31, Joel Holdsworth <jholdsworth@nvidia.com> wrote:

>
> The inclusion of the coorporate copyright is a stipulation of the
> company code release process.

This doesn't seem right to me.

It seems very odd that there's a patch that just adds a copyright notice, with no further notice.

What code does this cover and is now copyrighted? What are the license terms of the copyright holder? I think these things need to be made clear before this could be accepted.

Show 19 quoted lines

> ---
>  git-p4.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/git-p4.py b/git-p4.py
> index 5568d44c72..17e18265dc 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -5,6 +5,7 @@
>  # Author: Simon Hausmann <simon@lst.de>
>  # Copyright: 2007 Simon Hausmann <simon@lst.de>
>  #            2007 Trolltech ASA
> +#            2021 Nvidia Corporation
>  # License: MIT <http://www.opensource.org/licenses/mit-license.php>
>  #
>  # pylint: disable=invalid-name,missing-docstring,too-many-arguments,broad-except
> --
> 2.33.0
>