git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9824: fix wrong reference value

From
Luke Diamand <luke@diamand.org>
Date
Apr 29, 2016, 20:40 UTC
Message-ID
<CAE5ih7-AZCoJp2tO2KWRO4A9mWhdsNb_QTew93CmFCRh9kmATw@mail.gmail.com>
In-Reply-To
<ACC53CBE-D83A-49E9-9DC7-C99F485D3E55@gmail.com>
On 29 April 2016 at 21:29, Lars Schneider <larsxschneider@gmail.com> wrote:
Show 24 quoted lines
>
> On 29 Apr 2016, at 19:34, Junio C Hamano <gitster@pobox.com> wrote:
>
>> Lars Schneider <larsxschneider@gmail.com> writes:
>>
>>> 0492eb4 fixed a broken &&-chain in this test which broke the test as it
>>> checked for a wrong size. The expected size of the file under test is
>>> 39 bytes. The test checked that the size is 13 bytes. Fix the reference
>>> value to make the test pass, again.
>>>
>>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
>>> ---
>>
>> That breaking "fix" seems to have been acked by you.
>>
>> It was sort of clear that SZEDER didn't actually ran the test from
>> the patch, saying "As far as I can tell after eyeballing the test
>> script,", but you obviously didn't actually have a chance to test it
>> until now.
>>
>> Thanks for fixing it before it hits 'master'; this time I think it
>> is safe to assume that this was actually tested ;-)
>
> Yes! Lesson learned! Sorry Szeder!
How does the old saying go? If it hasn't been tested, it doesn't work!
Luke
Previous: Lars Schneider
Message 4 of 4 in “t9824: fix wrong reference value”
  1. t9824: fix wrong reference valueLars Schneider, Apr 29, 2016
  2. Junio C HamanoApr 29, 2016
  3. Lars SchneiderApr 29, 2016
  4. Luke DiamandApr 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.