Re: SP in committer line in fast-import stream

From: SASAKI Suguru <sss.sonik@gmail.com>
Date: Jul 18, 2011, 16:18 UTC
Message-ID: <CAE3X6mxbMBwd5O+md0J3M6DUu38Q1uzDHNhAU7iGbqYVm2TyRw@mail.gmail.com>
In-Reply-To: <loom.20110718T172927-173@post.gmane.org>

Hi,

2011-07-19 Dmitry Ivankov <divanorama@gmail.com>:

Show 15 quoted lines

> The problem is with git-fast-import that it doesn't verify the format strictly
> here.
> For example following (no LT) will pass:
> <name> SP <email> GT
> The second problem is that it generates "bad" committer, in fact name-email is
> used as-is, so at least it should convert absent name to a empty name. Or maybe
> just fix the format to make string obligatory.
> There even is a third minor problem, fsck will report confusing "missing space"
> for the no-LT example.
>
> Third one is a clear.
> Your one is the second one, while internally it pulls the first one too.
>
> The shortest fix is to read documentation as
> 'committer' SP <name> SP LT <email> GT SP <when> LF

Thanks. I understand what happens. For now, I'll write some wrapper around git-fast-import as a workaound for this.

But, if git-fast-import successfully import and git-fsck will confuse, aren't some fixes necessary? It might be too done if git-fast-import will check as if git-fsck does, but I think some simple checks will help us.

Any comments?

Regards,

-- 
SASAKI Suguru
  mailto:sss.sonik@gmail.com