git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] myFirstContribition: answering questions is not the end of the story

From
Philippe Blain <levraiphilippeblain@gmail.com>
Date
Nov 21, 2020, 02:54 UTC
Message-ID
<CADtb9Dw6+g61vNAvhdWqecMwh_M=nW6Ot21Cwy1wyP9EtDkN7g@mail.gmail.com>
In-Reply-To
<xmqq3613vrtx.fsf@gitster.c.googlers.com>
Hi Junio,
Le ven. 20 nov. 2020, à 21 h 50, Junio C Hamano <gitster@pobox.com> a écrit :
Show 20 quoted lines
>
> A review exchange may begin with a reviewer asking "what did you
> mean by this phrase in your log message (or here in the doc)?", the
> author answering what was meant, and then the reviewer saying "ah,
> that is what you meant---then the flow of the logic makes sense".
>
> But that is not the happy end of the story.  New contributors often
> forget that the material that has been reviewed in the above exchange
> is still unclear in the same way to the next person who reads it,
> until it gets updated.
>
> While we are in the vicinity, rephrase the verb "request" used to
> refer to comments by reviewers to "suggest"---this matches the
> contrast between "original" and "suggested" that appears later in
> the same paragraph, and more importantly makes it clearer that it is
> not like authors are to please reviewers' wishes but rather
> reviewers are merely helping authors to polish their commits.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---

I think this is a nice addition. However the patch title should probably be prefixed "MyFirstContribution" and not "myFirstContribition" ;)

Cheers!
Philippe.
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 7 in “myFirstContribition: answering questions is not the end of the story”
  1. myFirstContribition: answering questions is not the end of the storyJunio C Hamano, Nov 20, 2020
  2. Philip OakleyNov 20, 2020
  3. Junio C HamanoNov 20, 2020
  4. Emily ShafferNov 24, 2020
  5. Junio C HamanoDec 1, 2020
  6. Philippe BlainNov 21, 2020
  7. Junio C HamanoNov 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.