Re: Default ssh command

From: Aaron Hall <aaronchallmba@gmail.com>
Date: Jul 8, 2021, 13:50 UTC
Message-ID: <CADrEZfEzCzB1wq5_FaqH-pSK6vqYXXF0LFbXZ8fPKX_Mfr3QBw@mail.gmail.com>
In-Reply-To: <YOWsNk4GqNUPyHD5@camp.crustytoothpaste.net>

> Do you maybe have RequestTTY set in some SSH configuration file, like
> ~/.ssh/config?  You can also run "ssh -vvv HOSTNAME" to see if there are
> any config files.

That's it! Not sure why I put a wildcard RequestTTY force... I was probably just going through the man page and putting down things that looked like were what I wanted...

My urgency on this issue is gone. But unless git expects escape codes, perhaps it still should set them to none.

Show 5 quoted lines

> The problem is that on some systems "ssh" is something other than
> OpenSSH and we will likely break those systems.  That doesn't mean we
> can't do it if it's necessary, but it does mean that if this is a
> configuration issue, it would be better to fix the configuration if we
> can rather than potentially break systems needlessly.

I would expect it would be a compatible change but I don't have time to research it.

> This problem will also occur for tools like rsync and various other
> programs which expect the standard behavior for the ssh binary, so
> making a change here in Git is also not the right place if we can avoid
> it.

To me, it's weird that an improperly configured tool breaks another tool, and it seems that we could be more robust to that sort of problem without breaking anyone, but as you say we would need to verify we're not breaking anyone.

I suggest keeping this open as an issue, but that's up to you all.