Re: [GSoC PATCH v2] add -p: show user's hunk decision when selecting hunks
- From
Samuel Abraham <abrahamadekunle50@gmail.com>
- Date
- Jan 2, 2026, 07:20 UTC
- Message-ID
- <CADYq+fZX4sQswQZ2dHe1MZTC0BgyEG8+OUzVDgbNhoPa=MoTiw@mail.gmail.com>
- In-Reply-To
- <xmqqpl7tc5a9.fsf@gitster.g>
On Thu, Jan 1, 2026 at 11:54 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> > Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> writes: > > > When a user is interactively deciding which hunks to use or skip for > > staging, unstaging, stashing etc, there is no way to know the > > decision previously chosen for a hunk when navigating through the > > previous and next hunks using K/J respectively. > > > > Improve the UI to explicitly show if a user has previously decided to > > use a hunk (by pressing 'y') or skip the hunk (by pressing 'n'). > > This will improve clarity when and aid the navigation process for the > > user. > > > > Reported-by: Reported-by: Junio C Hamano <gitster@pobox.com> > > Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> > > --- > > Changes in v2: > > -------------- > > - Modified subject to indicate GSoC participation and user's hunk decision. > > - Modified the code to detect the user's decision for each front-end set > > that uses the interactive patch machinery > > - Changes the decision phrase to 'previous decision: _decision_' from > > 'Selected/Deselected' > > - Placed the decision phrase before the [choices] instead of after the [choices]. > > add-patch.c | 84 ++++++++++++++++++++++++++++++----------------------- > > 1 file changed, 47 insertions(+), 37 deletions(-) > > Doesn't this break t3701?
Thank you for the review Junio. Yes it does break t3701. I will fix the broken test cases to conform to the new code and send an updated version.
Thanks Abraham.