Re: git log --graph --no-graph can cause segfault

From: Emily Klassen <forivall@gmail.com>
Date: Feb 8, 2025, 05:51 UTC
Message-ID: <CADY4h_rOxG3eMR46SCL2Db4L6+++Tt5Ky6w5R8PPgofC+0iFxg@mail.gmail.com>
In-Reply-To: <Z6bhS7THkV2ovXfQ@danh.dev>

Yup, I built on `next` and it's still resulting in the segfault. However, I did end up figuring out the issue, and I'm sending a proper patch momentarily. Basically "revs->diffopt.output_prefix_data" needs to be nulled in the "--no-graph" argument parser in revision.c

~ Emily Marigold Klassen

On Fri, Feb 7, 2025 at 8:45 PM Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

Show 33 quoted lines

>
> On 2025-02-07 19:34:11-0800, Emily Klassen <forivall@gmail.com> wrote:
> > > What did you do before the bug happened? (Steps to reproduce your issue)
> >
> > $ git config --get alias.l
> > log --pretty=oneline --abbrev-commit --decorate --graph
> >
> > $ git --no-pager l --reverse --no-graph --name-status
> > e83c516331 Initial revision of "git", the information manager from hell
> > error: git died of signal 11
> >
> > > What did you expect to happen? (Expected behavior)
> >
> > I expect the commit listing to display successfully.
> >
> > > What happened instead? (Actual behavior)
> >
> > Git seems to have crashed. My best guess is that some state gets set with the
> > first `--graph` flag which is not cleared with the `--no-graph` flag.
> >
> > > What's different between what you expected and what actually happened?
> >
> > Git crashed.
>
> Given commands yields: "fatal: Out of memory, realloc failed" in my
> system. But it's fixed by jk/combine-diff-cleanup, which is merged
> into master.
>
> Would you try to run from master branch to see if your problem has
> been fixed?
>
> --
> Danh