git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs

From
Jacob Vosmaer <jacob@gitlab.com>
Date
Jan 20, 2021, 18:49 UTC
Message-ID
<CADMWQoPwNQafPcr2NvRcGzcWDwku1VYoGsKaKiBWSCRCvqY4Tg@mail.gmail.com>
In-Reply-To
<YAhYHUcdynbWyhwo@nand.local>

I also spent time being confused about what is going on, and wondering if that other ref iteration ever worked. I went as far as inspecting git-verify-pack -v output to look at object order. :)

On the other hand, through working on this I learned that include-tag has pretty effective test coverage so if peel_ref didn't work or stopped working, we'd find out.

If there is a better way to write "for each tag + peel ref" I am happy to change the patch, just let me know what it should look like.

Best regards,

Jacob Vosmaer GitLab, Inc.

On Wed, Jan 20, 2021 at 5:19 PM Taylor Blau <me@ttaylorr.com> wrote:
Show 13 quoted lines
>
> On Wed, Jan 20, 2021 at 11:18:11AM -0500, Jeff King wrote:
> > So I think both the existing and the new calls using for_each_tag_ref()
> > are OK here.
>
> Indeed, I followed the same trail of calls as you did and reached the
> same conclusion, but didn't write any of it down here since I thought it
> wasn't worthwhile.
>
> But, yes, I agree that both are safe.
>
> Thanks,
> Taylor
Previous: Taylor BlauNext: Jeff King
Message 6 of 11 in “builtin/pack-objects.c: avoid iterating all refs”
  1. 0/1 builtin/pack-objects.c: avoid iterating all refsJacob Vosmaer, Jan 20, 2021
  2. 1/1 builtin/pack-objects.c: avoid iterating all refsJacob Vosmaer, Jan 20, 2021
  3. Taylor BlauJan 20, 2021
  4. Jeff KingJan 20, 2021
  5. Taylor BlauJan 20, 2021
  6. Jacob VosmaerJan 20, 2021
  7. Jeff KingJan 20, 2021
  8. Jacob VosmaerJan 20, 2021
  9. Taylor BlauJan 20, 2021
  10. Jeff KingJan 21, 2021
  11. Jacob VosmaerJan 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.