Re: Feature-request: git-bundle --quiet

From: Jacob Vosmaer <jacob@gitlab.com>
Date: Aug 12, 2019, 10:15 UTC
Message-ID: <CADMWQoP3tH7-e+3FCYkB7b7nf8v-HBQ1toDoje8G_hvD_LaDZw@mail.gmail.com>
In-Reply-To: <20190808104212.GA14189@sigill.intra.peff.net>

This is a tangent, but relevant: how do we feel about the fact that 'git bundle create' does not perform CRC32 checks when copying data out of an existing packfile?

See https://github.com/git/git/blob/v2.22.0/builtin/pack-objects.c#L2614-L2622 .

I understand the rationale of "skip CRC32 when serving a fetch", although I have no clue how much we gain from skipping it. But "pack to stdout means fetch" isn't quite accurate, as it includes bundles.

Best regards,

Jacob Vosmaer GitLab, Inc.

Best regards,

Jacob Vosmaer GitLab, Inc.

On Thu, Aug 8, 2019 at 12:42 PM Jeff King <peff@peff.net> wrote:

Show 22 quoted lines

>
> On Tue, Aug 06, 2019 at 07:19:11PM +0000, Robin H. Johnson wrote:
>
> > I started trying to make a stab at implementing this, but the code
> > wasn't standing out for it. Hopefully somebody else has poked at it
> > before:
> >
> > I'd like to have a --quiet option for git-bundle, such that only errors
> > are sent to stderr, and not the packing progress.
>
> This seems like a reasonable thing to want.
>
> It looks like you'd have to teach cmd_bundle() to use parse_options(),
> parse a quiet flag, and then pas that down to create_bundle(). Then it
> would pass it along to write_pack_data(), which would decide whether to
> pass "-q".
>
> That would allow:
>
>   git bundle --quiet create foo.bundle ...
>
> -Peff