git client erroneously downloads files when --filter=blob:none and filtering unsupported
- From
- John Giorshev <john.giorshev1@gmail.com>
- Date
- Feb 22, 2025, 15:01 UTC
- Message-ID
- <CADJmAEiE=9Ar8CJFRWeN9f0i7TVDOF7VcV+4f-UaPw0m6Frh6w@mail.gmail.com>
The git client, in my opinion, erroneously downloads files when --filter=blob:none is specified and the server does not support filtering. I created a related question on this before coming here:
https://stackoverflow.com/q/79413099/15534181
Instead of giving a warning, it should instead error and exit. From a user perspective, when I request "don't pull down the file contents" and it does it anyway under some circumstances, this is unexpected. In my case it caused performance degradations on a repo scanner.
I propose something like this:
https://github.com/jagprog5/git/commit/c4bd8c9640c1491dc6e23acf31fa0230485b68b1
This is not backwards compatible. My question is, how best should this be handled? Is this breaking change ok? Or should there instead be a new CLI arg or config which enabled this new behaviour. Looking for advice, thanks.