git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] grep: add a grep.patternType configuration setting

From
J Smith <dark.panda@gmail.com>
Date
Aug 3, 2012, 18:22 UTC
Message-ID
<CADFUPge8LdBKHFrs32gFtzFwvvbK6OSxfMBdHF6fyRwtcCocTw@mail.gmail.com>
In-Reply-To
<7vsjc4aq0b.fsf@alter.siamese.dyndns.org>
On Fri, Aug 3, 2012 at 12:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
>
> Much nicer than the drafts in earlier discussion.  One micronit is
> that probably it is preferrable to do '!=' instead of '>', as we are
> only trying to see if it is unspecified on the command line (hence
> need to pay attention to configuration) and do not care how the
> enums are ordered, but that is nothing that requires a re-roll.
True enough. Old habits I guess, eh?
Show 9 quoted lines
> All the new tests in the script looked very well thought out.
>
> I noticed that this particular one will still succeed when somebody
> breaks your code to ignore the configuration (as -G "a+b" would give
> the expected match) or give higher precedence to the configuration
> (as fixed "a+b" also will give the expected match).  Not that it is
> wrong to have such a test that is unlikely to catch certain kinds of
> regressions in the suite, and the particular kind of breakage will
> be caught by the next test (snipped) anyway.
Yeah, that test is kind of iffy, but does no harm I suppose.
> Will queue.  Thanks.

Great, thanks. Been an informative experience for a first-time git patcher. Cheers.

Previous: Junio C Hamano
Message 3 of 3 in “grep: add a grep.patternType configuration setting”
  1. grep: add a grep.patternType configuration settingJ Smith, Aug 3, 2012
  2. Junio C HamanoAug 3, 2012
  3. J SmithAug 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.