Re: [PATCH 6/6] template: Fix comment indentation in pre-rebase hook
- From
Richard Hartmann <richih.mailinglist@gmail.com>
- Date
- Jun 10, 2013, 23:03 UTC
- Message-ID
- <CAD77+gSX1ggBWHhGwxRUBPGQ6ONJd76SO-3tU05QT47iKCv9hg@mail.gmail.com>
- In-Reply-To
- <7vobbdefr7.fsf@alter.siamese.dyndns.org>
On Tue, Jun 11, 2013 at 12:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> [PATCH 1/6] templates: Fewer subprocesses in pre-commit hook > > I agree with Peff that "less fork" is a bad justification for this > change, and also > > echo 'First line > second line > third lie' > > looks somewhat bad.
The repeated echo also looks bad, imo. Also, 2/6 depends on this to save lines. Should I rewrite with EOF, keep as is, or drop?
> [PATCH 2/6] templates: Reformat pre-commit hook's message > > I think it is a good thing to make the output short by widening.
As I said, 2/6 depends on 1/6 to some extent.
Show 7 quoted lines
> [PATCH 4/6] Documentation: Update manpage for pre-commit hook > > I debated myself if it should say "The hook _by default_ prevents > addition of non-ASCII filenames", hinting that it can be > configured out if it is unwanted. > > Other than that, I think it is a good addition.
Will update once I know the complete TODO.
> [PATCH 5/6] templates: Fix ASCII art in pre-rebase hook > > Good, but see Peff's comments on the explanation.
OK.
Show 6 quoted lines
> [PATCH 6/6] template: Fix comment indentation in pre-rebase hook > > After reading the original once again, it is fine as-is without > the change at all, I think. Alternatively, "if these match" and > "if this is empty" lines can be flushed to the left, which also is > readable.
I think I will flush and capitalize, then.
Richard