Re: [PATCH v7 0/3] RUNTIME_PREFIX relocatable Git

From: Daniel Jacques <dnj@google.com>
Date: Mar 26, 2018, 13:03 UTC
Message-ID: <CAD1RUU-EoitBdoXL_JQoP+Q9BuA_6Fq65Ra-f+Atz8YNOV3Cig@mail.gmail.com>
In-Reply-To: <877epzyi0b.fsf@evledraar.gmail.com>

On Sun, Mar 25, 2018 at 5:15 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> This looks good to me this time around, couple of small nits (maybe
> Junio can amend while queuing):

>   * You add a dependnecy typo in 2/3 but fix it again in 3/3. Should be
>     squashed.

d'oh, I'll fix that in my local copy so that if I do end up needing to upload a new version, it's available.

>   * s/\Q${gitexecdir_relative}\E$// in 2/3 can be done less verbosely as
>     s/\Q$gitexecdir_relative\E$//. Discussed before in

https://public-inbox.org/git/CAD1RUU-3Q_SYvJorU+vEY2-0CPMZ1eL-41Z6eL7Sq4USiJ0U+w@mail.gmail.com/

>     seems like something you just forgot about.

Oh sorry, I must have missed that. I have a personal preference for adding brackets for clarity; it leaked into this patch set. I did implement most of the suggestion, which was to use the escaped Q/E instead of equals.

Stylistically I still prefer the braces, but I'll defer to you and remove them in my pending patch set in case I'm asked to submit another version.

Cheers! -Dan