Re: [PATCH] Documentation/Makefile: Allow custom XMLTO binary
- From
Dave Borowitz <dborowitz@google.com>
- Date
- Sep 19, 2012, 20:49 UTC
- Message-ID
- <CAD0k6qTMm7MKLYOOMaB72cWc=Z8nJfe8qseWfyM6x_NzCorgZg@mail.gmail.com>
- In-Reply-To
- <7vehlxhp0v.fsf@alter.siamese.dyndns.org>
On Wed, Sep 19, 2012 at 10:59 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> dborowitz@google.com writes: > >> From: Dave Borowitz <dborowitz@google.com> >> >> Signed-off-by: Dave Borowitz <dborowitz@google.com> >> --- > > Thanks; the patch sort-of makes sense but makes me wonder what your > use case is. Do you have xmlto2 program you want to use in place of > xmlto or you have xmlto but not on your $PATH?
The latter; I can easily symlink it into my $PATH of course. But since I was already specifying ASCIIDOC on the make command line for the same reason, I was surprised to find I couldn't also specify XMLTO, hence the patch.
Show 24 quoted lines
>> Documentation/Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/Makefile b/Documentation/Makefile >> index cf5916f..b045628 100644 >> --- a/Documentation/Makefile >> +++ b/Documentation/Makefile >> @@ -47,6 +47,7 @@ man7dir=$(mandir)/man7 >> ASCIIDOC=asciidoc >> ASCIIDOC_EXTRA = >> MANPAGE_XSL = manpage-normal.xsl >> +XMLTO=xmlto >> XMLTO_EXTRA = >> INSTALL?=install >> RM ?= rm -f >> @@ -245,7 +246,7 @@ manpage-base-url.xsl: manpage-base-url.xsl.in >> >> %.1 %.5 %.7 : %.xml manpage-base-url.xsl >> $(QUIET_XMLTO)$(RM) $@ && \ >> - xmlto -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $< >> + $(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $< >> >> %.xml : %.txt >> $(QUIET_ASCIIDOC)$(RM) $@+ $@ && \