git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR

From
Dave Borowitz <dborowitz@google.com>
Date
Apr 28, 2014, 20:52 UTC
Message-ID
<CAD0k6qSxBq+VAZ2CH-vR-Pyk4FjKKeJmngBU5T9Z-cwSH1LffQ@mail.gmail.com>
In-Reply-To
<20140428205058.GQ9218@google.com>
On Mon, Apr 28, 2014 at 1:50 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 9 quoted lines
>> $ echo -e 'ifndef FOO\n\t$(error bad things)\nendif\n\nfoo:\n\ttouch
>> foo' > mk1 && make -f mk1 foo
>> mk1:2: *** commands commence before first target.  Stop.
>> $ echo -e 'ifndef FOO\n  $(error bad things)\nendif\n\nfoo:\n\ttouch
>> foo' > mk2 && make -f mk2 foo
>> mk2:2: *** bad things.  Stop.
>
> Gah.  Maybe it should be left-justified to avoid accentally breaking
> it again.

I am ok with that on the basis that it is better to be ugly but obvious. I suspect if the Makefile were more littered with conditional $(error)s we would reconsider using tabs as indentation.

> Thanks.
> Jonathan
Previous: Jonathan NiederNext: Junio C Hamano
Message 6 of 10 in “Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR”
  1. Makefile: default to -lcurl when no CURL_CONFIG or CURLDIRDave Borowitz, Apr 28, 2014
  2. Jonathan NiederApr 28, 2014
  3. Dave BorowitzApr 28, 2014
  4. Dave BorowitzApr 28, 2014
  5. Jonathan NiederApr 28, 2014
  6. Dave BorowitzApr 28, 2014
  7. Junio C HamanoApr 28, 2014
  8. Junio C HamanoApr 28, 2014
  9. Junio C HamanoApr 28, 2014
  10. Dave BorowitzApr 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.