Re: [Outreachy PATCH v7 2/3] environment: stop using core.sparseCheckout globally

From: Bello Olamide <belkid98@gmail.com>
Date: Feb 26, 2026, 16:24 UTC
Message-ID: <CAD=f0L-_zq5ACD1mbfyBn3bTSu_X2emeMjv+Cfu5B5zyH8=DFw@mail.gmail.com>
In-Reply-To: <xmqqikbj5y0y.fsf@gitster.g>

On Thu, 26 Feb 2026 at 16:23, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > On Mon, Feb 16, 2026 at 5:39 PM Olamide Caleb Bello <belkid98@gmail.com> wrote:
> >
> >> @@ -670,7 +672,8 @@ static void clear_skip_worktree_from_present_files_full(struct index_state *ista
> >>
> >>  void clear_skip_worktree_from_present_files(struct index_state *istate)
> >>  {
> >> -       if (!core_apply_sparse_checkout ||
> >> +       struct repo_config_values *cfg = repo_config_values(the_repository);
> >
> > Nit: it would be better with a blank line here.
> >
> >> +       if (!cfg->apply_sparse_checkout ||
> >>             sparse_expect_files_outside_of_patterns)
> >>                 return;
>
> OK.  Agreed and locally amended.
>
> Let's merge the topic down to 'next'.

Thank you very much for all your assistance.