Re: [PATCH] Add testcase for needless objects during a shallow fetch
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Aug 31, 2013, 01:25 UTC
- Message-ID
- <CACsJy8Dv7tVG_oWcPvNTy-zxD7axZxoXHcE1=TFwTv9+wGFCOQ@mail.gmail.com>
- In-Reply-To
- <CACsJy8BDxkpFG=nfVENeAHMyhdokwvbpxu26m0RtHou_WK2Mkw@mail.gmail.com>
On Thu, Aug 29, 2013 at 4:50 PM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 12 quoted lines
> On Wed, Aug 28, 2013 at 11:02 PM, Matthijs Kooijman <matthijs@stdin.nl> wrote: >> This is a testcase that checks for a problem where, during a specific >> shallow fetch where the client does not have any commits that are a >> successor of the new shallow root (i.e., the fetch creates a new >> detached piece of history), the server would simply send over _all_ >> objects, instead of taking into account the objects already present in >> the client. > > Thanks. This reminds me I should add a test case in the 4/6 to > demonstrate the regression and let it verify again in 6/6 that the > temporary regression is gone. Will reroll the series with your patch > included.
No. It's too hard. The difference is what base a delta object use and checking that might not be entirely reliable because the algorithm in pack-objects might change some day.
-- Duy