Re: [PATCH 1/2] config: allow config_with_options() to handle any repo
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Aug 27, 2019, 09:26 UTC
- Message-ID
- <CACsJy8Dry7MfKBi5EKw4Ka9r63QVmDjPv9nAozS0mC6Z7-sG=w@mail.gmail.com>
- In-Reply-To
- <4920d3c474375abb39ed163c5ed6138a5e5dccc6.1566863604.git.matheus.bernardino@usp.br>
On Tue, Aug 27, 2019 at 6:57 AM Matheus Tavares <matheus.bernardino@usp.br> wrote:
> > Currently, config_with_options() relies on the global the_repository > when it has to configure from a blob.
Not really reading the patch, but my last experience with moving config.c away from the_repo [1] shows that there are more hidden dependencies, in git_path() and particularly the git_config_clear() call in git_config_set_multivar_... Not really sure if those deps really affect your goals or not. Have a look at that branch, filtering on config.c for more info (and if you want to pick up some patches from that, you have my sign-off).
[1] https://gitlab.com/pclouds/git/commits/submodules-in-worktrees
-- Duy