Re: [PATCH 6/9] pretty: two phase conversion for non utf-8 commits

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sep 24, 2012, 01:21 UTC
Message-ID: <CACsJy8DoBwLccaGGFqDfW2F3isZ74S2FLGXW3bDOcr2X-hQc3w@mail.gmail.com>
In-Reply-To: <189332269.134567.1348408475044.JavaMail.root@dewire.com>

On Sun, Sep 23, 2012 at 8:54 PM, Robin Rosenberg <robin.rosenberg@dewire.com> wrote:

>> This of course only works with encodings that are compatible with
>> Unicode.
> Such as? Unicode was defined to encompass all knows encodings.

Just a precaution because I have never read Unicode standard (and it keeps getting updated, hence "incomplete")

Show 12 quoted lines

>
>> -static size_t format_commit_one(struct strbuf *sb, const char
>> *placeholder,
>> +static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */
>> +                             const char *placeholder,
>>                               void *context)
>>  {
>>       struct format_commit_context *c = context;
>
> Which parameter does the comment apply to? I believe most conventions
> nowadays include parameter documentation in the comment preceding
> the function header.

Yeah. I should have followed that.

Show 14 quoted lines

>> b/t/t6006/commit-msg.iso8859-1
>> new file mode 100644
>> index 0000000..f8fe808
>> --- /dev/null
>> +++ b/t/t6006/commit-msg.iso8859-1
>> @@ -0,0 +1,5 @@
>> +Test printing of complex bodies
>> +
>> +This commit message is much longer than the others,
>> +and it will be encoded in iso8859-1. We should therefore
>> +include an iso8859 character: �bueno!
>
> "8859-1" to be exact. Only three 8859 encoding has the
> character.

Yep. But i'll probably need a closer look at t6006. It seems there's a few "upside down exclamation" (not sure what it's called) in UTF-8 in that test. I'll fix the text too.

-- 
Duy