Re: [PATCH v12 00/20] index-helper/watchman
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jun 25, 2016, 16:42 UTC
- Message-ID
- <CACsJy8Dmr8QSSMycetPH2WNECc0A=cOzG6o+jffT4RSWwVC+Vw@mail.gmail.com>
- In-Reply-To
- <CACsJy8CKxzpphPB4iST_QzP1BqxYZuPKftyvsovwphysXzGa3A@mail.gmail.com>
On Sat, Jun 25, 2016 at 3:28 PM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 6 quoted lines
> On Thu, May 19, 2016 at 11:45 PM, David Turner <dturner@twopensource.com> wrote: >> Of course, as soon as I pinged on the previous version, I noticed an issue. >> ... > > A bit off-topic, but you may want to cut a release for libwatchman > (even 0.1.0 would do) so it can be properly packaged.
And I'm done with v12! I think most of my comments are minor thing except the "really || cache_errno == EINVAL" change (which I still don't see how it's related to watchman).
-- Duy