Re: [PATCH 4/6] dir.c::match_pathname(): pay attention to the length of string parameters
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Mar 29, 2013, 08:45 UTC
- Message-ID
- <CACsJy8DisE8UNZzqmOFxPqw=bmFiHgE5-ao83ciGNUV9Sc9-gA@mail.gmail.com>
- In-Reply-To
- <20130328214821.GD10936@sigill.intra.peff.net>
On Fri, Mar 29, 2013 at 4:48 AM, Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
> - return fnmatch_icase(pattern, name, FNM_PATHNAME) == 0; > + return fnmatch_icase_mem(pattern, patternlen, > + name, namelen, > + FNM_PATHNAME) == 0; > }
I think you (or Junio) should rebase this on maint. Since c41244e (included in maint), this call is turned to wildmatch(WM_PATHNAME) and WM_PATHNAME is _not_ the same as FNM_PATHNAME for patterns like "foo/**/bar". A diff between next and pu shows me that WM_PATHNAME is incorrectly converted to FNM_PATHNAME. I hope that is the cause of all breakages Junio found out on pu.
-- Duy