Re: [Breakage] 2.22.0-rc1 - t0211-trace2-perf.sh

From: Duy Nguyen <pclouds@gmail.com>
Date: May 21, 2019, 11:59 UTC
Message-ID: <CACsJy8DhsU6CL95W9gsWaTSnN+_7Z_+Q7yPjhuDRRKfCrhnz2w@mail.gmail.com>
In-Reply-To: <87a7fguiwn.fsf@evledraar.gmail.com>

On Tue, May 21, 2019 at 6:51 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 9 quoted lines

> But the real bug looks like the trace2 code unconditionally depending on
> pthreads, even though NonStop has 'NO_PTHREADS = UnfortunatelyYes'
> defined.
>
> That's why we get this th%d:unknown stuff, the trace2/tr2_tls.c code
> using pthreads is failing with whatever pthread-bizarro NonStop has.
>
> That seems easy enough to "fix", just always fake up "main" if we don't
> have pthreads, but perhaps Jeff H. has another opinion on it...

That's not NonStop. thread-utils.h (re)defines pthread_getspecific() to return NULL when NO_PTHREADS, which triggers this I think.

-- 
Duy