Re: [PATCH/RFC] commit: new option to abort -a something is already staged
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Aug 23, 2018, 14:49 UTC
- Message-ID
- <CACsJy8DdZLxdA4XSVVBSpeZaF+q6=81LxecYea2JtJ6-Krnk-A@mail.gmail.com>
- In-Reply-To
- <20180823021547.GE92374@aiede.svl.corp.google.com>
On Thu, Aug 23, 2018 at 4:15 AM Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 12 quoted lines
> > The remaining question becomes scripts. A script might do > > > > ... modify old-file and create new-file ... > > git add new-file > > git commit -m "some great message" > > > > which would trip this error. For that matter, humans might do that, > > too. Could the check detect this case (where the only changes in the > > index are additions of new files) and treat it as non-destructive? > > (where the only changes in the index are additions of new files *that > match the worktree*)
I don't think my change would affect this case. If "git commit" does not change the index by itself, there's no point in stopping it.
-- Duy