Re: [PATCH] config.h: fix hdr-check warnings

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 14, 2019, 09:59 UTC
Message-ID: <CACsJy8DceS3J_kmA9p66J1ecYTZ3=-ky5mT-NwMT7uKkVtUmdA@mail.gmail.com>
In-Reply-To: <13179d3e-f1d5-55f7-3572-829b5ddc9827@ramsayjones.plus.com>

On Mon, Jan 14, 2019 at 4:02 AM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 16 quoted lines

>
>
> commit 8f7c7f5555 ("config.c: add repo_config_set_worktree_gently()",
> 2018-12-27) adds three function declarations that cause the hdr-check
> make target to complain. The hdr-check complaint is caused by placing
> the new declarations, which include 'struct repository *' parameters,
> before the declaration of 'struct repository'. Move the struct
> declaration to the top of the file.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Duy,
>
> If you need to re-roll your 'nd/config-move-to' branch, could you please
> squash this into the relevant patch (commit 8f7c7f5555).

Hi Junio, I notice you squashed in all changes of this series (I was preparing to resend last weekend). Will you squash this in too? It's of course ok if you don't, I'll resend.

> BTW, none of the three new functions are called outside of config.c on
> the 'pu' branch - I assume future patches will add some calls to these
> functions (yes?).

Yes. Once this part lands I'll submit the fun stuff.

-- 
Duy