Re: [PATCH] general style: replaces memcmp() with starts_with()

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 12, 2014, 13:51 UTC
Message-ID: <CACsJy8DUhqn_ESzT-KpAdrWvWcLbPUiXDmBZXu7UtHU+M0GLgw@mail.gmail.com>
In-Reply-To: <1394631854-11208-1-git-send-email-quintus.public@gmail.com>

On Wed, Mar 12, 2014 at 8:44 PM, Quint Guvernator <quintus.public@gmail.com> wrote:

Show 13 quoted lines

> diff --git a/builtin/apply.c b/builtin/apply.c
> index a7e72d5..8f21957 100644
> --- a/builtin/apply.c
> +++ b/builtin/apply.c
> @@ -846,8 +846,8 @@ static int has_epoch_timestamp(const char *nameline)
>          * YYYY-MM-DD hh:mm:ss must be from either 1969-12-31
>          * (west of GMT) or 1970-01-01 (east of GMT)
>          */
> -       if ((zoneoffset < 0 && memcmp(timestamp, "1969-12-31", 10)) ||
> -           (0 <= zoneoffset && memcmp(timestamp, "1970-01-01", 10)))
> +       if ((zoneoffset < 0 && starts_with(timestamp, "1969-12-31")) ||
> +           (0 <= zoneoffset && starts_with(timestamp, "1970-01-01")))
>                 return 0;

It is not a plain search/replace. starts_with(..) == !memcmp(...). So you need to negate every replacement.

-- 
Duy