Re: [PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 23, 2013, 13:38 UTC
Message-ID: <CACsJy8DSQMQ_mLxTXDL3oHuV9DdRv9MFH0-h=KzaBEhXtkLpZQ@mail.gmail.com>
In-Reply-To: <1358948067-2792-1-git-send-email-pclouds@gmail.com>

On Wed, Jan 23, 2013 at 8:34 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 11 quoted lines

> add_submodule_odb() can be used to import objects from another
> repository temporarily. After this point we don't know which objects
> are ours, which are external. If we create an object that refers to an
> external object, next time git runs, it may find a hole in the object
> graph because the external repository may not be imported. The same
> goes for pointing a ref to an external SHA-1.
>
> To protect ourselves, once add_submodule_odb() is used:
>
>  - trees, tags and commits cannot be created
>  - refs cannot be updated

.. and soon after I pressed send, I realized I missed at least two other places write should not be allowed:

 - index
 - reflog

But the general idea is probably more important than implementation details at this stage.

-- 
Duy