Re: [PATCH v2] add: add --bulk to index all objects into a pack file

From: Duy Nguyen <pclouds@gmail.com>
Date: Oct 4, 2013, 07:19 UTC
Message-ID: <CACsJy8DOziJ9z2p-2BttJf=zZUC6GsRVtKru3R6Kn32-B0tAdA@mail.gmail.com>
In-Reply-To: <vpqfvshecjg.fsf@anie.imag.fr>

On Fri, Oct 4, 2013 at 2:10 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 6 quoted lines

> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> except that it does not deltifies nor sort objects.
>
> I think this should be mentionned in the doc. Otherwise, it seems like
> "git add --bulk" is like "git add && git repack".

Yep. Will do.

> BTW, will the next "git gc" be efficient after a "add --bulk"? I mean:
> will it consider the pack as "already pack" and let it as-is, without
> deltification, or will it get a chance to actually repack efficiently?

gc does "repack -A" so all separate packs will be merged. It may delay gc time though because it'll take more time to hit the loose object limit. I think pack-objects will try to deltify so we're good. If we produce bad deltas in --bulk then that's another story because pack-objects will try to blindly reuse them.

-- 
Duy