Re: [PATCH] list-objects: mark fewer commits as edges for non-shallow clones
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Dec 11, 2014, 10:51 UTC
- Message-ID
- <CACsJy8DM17je-FJ7vq3SFZJWPL5KbZ=kE=iTFQ0X0bZUpKuNmg@mail.gmail.com>
- In-Reply-To
- <1418269615-139571-1-git-send-email-sandals@crustytoothpaste.net>
On Thu, Dec 11, 2014 at 10:46 AM, brian m. carlson <sandals@crustytoothpaste.net> wrote:
Show 7 quoted lines
> In commit fbd4a70 (list-objects: mark more commits as edges in > mark_edges_uninteresting - 2013-08-16), we made --thin much more > aggressive by reading lots more trees. This produces much smaller packs > for shallow clones; however, it causes a significant performance > regression for non-shallow clones with lots of refs (23.322 seconds vs. > 4.785 seconds with 22400 refs). Limit this extra edge-marking to > shallow clones to avoid poor performance.
I'm glad it's now working better for you. Out of curiosity, have you enabled pack bitmap on this repo? I would expect it to reduce time some (or a lot) more, or we would find something to optimize further.
-- Duy