Re: [PATCH] add: add --chmod=+x / --chmod=-x options

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 8, 2016, 11:46 UTC
Message-ID: <CACsJy8DC_8LkZUCe=NY6wbg0+jTtwQTPE1zM1da9Vq8-PfyrsA@mail.gmail.com>
In-Reply-To: <20160531220818.GB46739@zoidberg>

On Wed, Jun 1, 2016 at 5:08 AM, Edward Thomson <ethomson@edwardthomson.com> wrote:

Show 5 quoted lines

> @@ -263,6 +265,7 @@ static struct option builtin_add_options[] = {
>         OPT_BOOL( 0 , "refresh", &refresh_only, N_("don't add, only refresh the index")),
>         OPT_BOOL( 0 , "ignore-errors", &ignore_add_errors, N_("just skip files which cannot be added because of errors")),
>         OPT_BOOL( 0 , "ignore-missing", &ignore_missing, N_("check if - even missing - files are ignored in dry run")),
> +       OPT_STRING( 0 , "chmod", &chmod_arg, N_("(+/-)x"), N_("override the executable bit of the listed files")),

If this is only about +/-x, would --[no-]executable be a better option name?

-- 
Duy