Re: [PATCH v3 03/31] Add parse_pathspec() that converts cmdline args to struct pathspec

> On Sun, Jan 13, 2013 at 4:35 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> +static void parse_pathspec(struct pathspec *pathspec,
>> +                          unsigned magic_mask, unsigned flags,
>> +                          const char *prefix, const char **argv)
>> +{
>> +       struct pathspec_item *item;
>> +       const char *entry = *argv;
>> ...
>> +       for (i = 0; i < n; i++) {
>> +               const char *arg = argv[i];
>
> Nit: "*argv" was assigned to "entry" above. Reassign that variable instead?